adoroszlai commented on code in PR #5326:
URL: https://github.com/apache/ozone/pull/5326#discussion_r1383861330
##########
hadoop-ozone/dist/src/main/smoketest/s3/bucketdelete.robot:
##########
@@ -43,3 +43,21 @@ Delete non-existent bucket
${randStr} = Generate Ozone String
${result} = Execute AWSS3APICli and checkrc delete-bucket --bucket
nosuchbucket-${randStr} 255
Should contain ${result}
NoSuchBucket
+
+Delete bucket with incomplete multipart uploads
+ ${bucket} = Create bucket to be deleted
Review Comment:
> there are still failures in HA-secure acceptance test, maybe I missed
something
The test case fails when using a link, not a real bucket. Links do not
contain any keys, not even multipart upload parts. Thus they can always be
deleted (if allowed by ACL).
Please use `Create bucket` to create a real bucket with random name.
Also, please add `[tags] no-bucket-type` to this test case, since we do
not need to repeat it for various bucket types.
##########
hadoop-ozone/dist/src/main/smoketest/s3/bucketdelete.robot:
##########
@@ -43,3 +43,21 @@ Delete non-existent bucket
${randStr} = Generate Ozone String
${result} = Execute AWSS3APICli and checkrc delete-bucket --bucket
nosuchbucket-${randStr} 255
Should contain ${result}
NoSuchBucket
+
+Delete bucket with incomplete multipart uploads
+ ${bucket} = Create bucket to be deleted
+
+ # initiate incomplete multipart uploads (multipart upload is initiated but
not completed/aborted)
+ ${initiate_result} = Execute AWSS3APICli create-multipart-upload
--bucket ${bucket} --key incomplete-multipartkey
+ ${uploadID} = Execute and checkrc echo
'${initiate_result}' | jq -r '.UploadId' 0
Review Comment:
Nit: `Execute and checkrc` with 0 expected exit code can be simplified to
`Execute`.
https://github.com/apache/ozone/blob/ff3c071f52310289c01dafbe0a6939e8e65c5398/hadoop-ozone/dist/src/main/smoketest/lib/os.robot#L19-L22
```suggestion
${uploadID} = Execute echo
'${initiate_result}' | jq -r '.UploadId'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
