ivandika3 commented on code in PR #5326:
URL: https://github.com/apache/ozone/pull/5326#discussion_r1384230694


##########
hadoop-ozone/dist/src/main/smoketest/s3/bucketdelete.robot:
##########
@@ -43,3 +43,21 @@ Delete non-existent bucket
     ${randStr} =   Generate Ozone String
     ${result} =    Execute AWSS3APICli and checkrc    delete-bucket --bucket 
nosuchbucket-${randStr}    255
                    Should contain                     ${result}                
              NoSuchBucket
+
+Delete bucket with incomplete multipart uploads
+    ${bucket} =                Create bucket to be deleted

Review Comment:
   > The test case fails when using a link, not a real bucket. Links do not 
contain any keys, not even multipart upload parts. Thus they can always be 
deleted (if allowed by ACL).
   
   I see, thank you for the explanation.
   
   > Please use Create bucket to create a real bucket with random name.
   
   > Also, please add [tags]    no-bucket-type to this test case, since we do 
not need to repeat it for various bucket types.
   
   Understood, updated. Thanks for the help.
   



##########
hadoop-ozone/dist/src/main/smoketest/s3/bucketdelete.robot:
##########
@@ -43,3 +43,21 @@ Delete non-existent bucket
     ${randStr} =   Generate Ozone String
     ${result} =    Execute AWSS3APICli and checkrc    delete-bucket --bucket 
nosuchbucket-${randStr}    255
                    Should contain                     ${result}                
              NoSuchBucket
+
+Delete bucket with incomplete multipart uploads
+    ${bucket} =                Create bucket to be deleted
+
+    # initiate incomplete multipart uploads (multipart upload is initiated but 
not completed/aborted)
+    ${initiate_result} =       Execute AWSS3APICli     create-multipart-upload 
--bucket ${bucket} --key incomplete-multipartkey
+    ${uploadID} =              Execute and checkrc     echo 
'${initiate_result}' | jq -r '.UploadId'    0

Review Comment:
   Updated accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to