Re: [PR] HDDS-9296. Add Swagger UI for Recon REST APIs [ozone]

[via GitHub]

ArafatKhan2198 commented on PR #5509:
URL: https://github.com/apache/ozone/pull/5509#issuecomment-1801184877

   > Hello, thanks for the review @adoroszlai @ArafatKhan2198. In the latest 
commit I changed it to a relative path, which should allow the yaml file to be 
detected irrespective of how the files are being stored. Verified this patch 
for the following:
   > 
   > * By running the same steps as in [HDDS-9296. Add Swagger UI for Recon 
REST APIs #5509 
(comment)](https://github.com/apache/ozone/pull/5509#discussion_r1383483505)
   > 
   > <img alt="Screenshot 2023-11-06 at 21 38 32" width="1728" 
src="https://user-images.githubusercontent.com/43001336/280773472-a536bdb9-5136-430a-a98c-e5fe62d00fa7.png";>
   > * By directly running `hugo serve` on the docs folder
   > 
   > <img alt="Screenshot 2023-11-06 at 21 40 53" width="1728" 
src="https://user-images.githubusercontent.com/43001336/280773929-9c319c77-cc9c-4efb-a97c-46a50fcf9d10.png";>
   > * Via building the whole project, running it using `docker-compose` and 
then visiting the UI
   > 
   > <img alt="Screenshot 2023-11-06 at 22 17 00" width="1728" 
src="https://user-images.githubusercontent.com/43001336/280783775-2c4ec1e2-e24c-4e87-a1d6-60686325a807.png";>
   
   Thanks for the changes @devabhishekpal Ill take a look!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org