devabhishekpal commented on PR #5509: URL: https://github.com/apache/ozone/pull/5509#issuecomment-1806714944
Thanks @ArafatKhan2198 for the review. I have made the changes. The only thing which isn't quite feasible is from https://github.com/apache/ozone/pull/5509#pullrequestreview-1725354077 regarding setting of the port value. Swagger will determine the port from the localhost value. While we can do that via JS, maybe add an option for the users to specify the end-port, most users might not use it, since we are returning 404 either way because of no recon instance, and this is just an interactive documentation - not a replacement for API calls. But do let me know if you want that change, will look into it. The other changes have been addressed in the latest commit. Please do take a look once, specially in the `/utilization/containerCount` API, and let me know if the description is okay, and whether containerSize parameter is mandatory or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
