adoroszlai commented on code in PR #5529:
URL: https://github.com/apache/ozone/pull/5529#discussion_r1398240862
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataReader.java:
##########
@@ -325,8 +325,10 @@ public OmKeyInfo lookupFile(OmKeyArgs args) throws
IOException {
public ListKeysResult listKeys(String volumeName, String bucketName,
String startKey, String keyPrefix, int maxKeys) throws IOException {
long startNanos = Time.monotonicNowNanos();
- ResolvedBucket bucket = ozoneManager.resolveBucketLink(
- Pair.of(volumeName, bucketName));
+ ResolvedBucket bucket = captureLatencyNs(
+ perfMetrics.getListKeysResolveBucketLatencyNs(),
+ () -> ozoneManager.resolveBucketLink(
+ Pair.of(volumeName, bucketName)));
Review Comment:
Indentation is a bit odd, but it can be fixed in a follow-up patch (whenever
this file is being touched next time).
```suggestion
ResolvedBucket bucket = captureLatencyNs(
perfMetrics.getListKeysResolveBucketLatencyNs(),
() -> ozoneManager.resolveBucketLink(
Pair.of(volumeName, bucketName)));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
