kerneltime commented on PR #5529: URL: https://github.com/apache/ozone/pull/5529#issuecomment-1821459720
> Thanks @muskan1012 for updating the patch. > > On second look, I wonder if we should record metrics for `resolveBucketLink` and `checkAcls` as part of each operation, or collectively. In other words, should we have: > > * "resolve bucket link for X", "resolve bucket link for Y" etc. where X, Y are operations like `listKeys`, `lookupKey`, etc. > * OR a single "resolve bucket link" > > elapsed time metric? > > In either case, is the end goal to add these sub-operation metrics to every operation? In production, it would be good to have a dashboard that can list the breakdown per OM request without noise. Thus, having these metrics on a per operation basis will be more focused and help identify any ranger issue that might be application for a specific operation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
