adoroszlai opened a new pull request, #5631: URL: https://github.com/apache/ozone/pull/5631
## What changes were proposed in this pull request? Managed RocksDB objects have optional leak detection (enabled in integration tests). Objects that extend `ManagedObject` report leak with stack trace, but most other types lack this detail, making it more difficult to find the source of the leak: ``` [Finalizer] WARN managed.ManagedRocksObjectUtils (ManagedRocksObjectUtils.java:reportLeak(71)) - ManagedWriteBatch is not closed properly ``` This change improves it by adding stack trace information for these objects. https://issues.apache.org/jira/browse/HDDS-9724 ## How was this patch tested? Applied the patch on top of https://github.com/devmadhuu/ozone/commit/81fb066918893cea15e4f49bb1af71d7d971cde6, which was not closing `RDBBatchOperation`. Ran `TestReconTasks`, checked log for stack trace: ``` [Finalizer] WARN managed.ManagedRocksObjectUtils (ManagedRocksObjectUtils.java:reportLeak(67)) - ManagedWriteBatch is not closed properly StackTrace for unclosed instance: org.apache.hadoop.hdds.utils.db.managed.ManagedWriteBatch.<init>(ManagedWriteBatch.java:32) org.apache.hadoop.hdds.utils.db.RDBBatchOperation.<init>(RDBBatchOperation.java:332) org.apache.hadoop.ozone.recon.TestReconTasks.testMissingContainerDownNode(TestReconTasks.java:157) ... ``` Regular CI: https://github.com/adoroszlai/ozone/actions/runs/6929643804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
