duongkame commented on code in PR #5631:
URL: https://github.com/apache/ozone/pull/5631#discussion_r1399628562


##########
hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedBloomFilter.java:
##########
@@ -20,14 +20,20 @@
 
 import org.rocksdb.BloomFilter;
 
+import static 
org.apache.hadoop.hdds.utils.db.managed.ManagedRocksObjectUtils.assertClosed;
+import static 
org.apache.hadoop.hdds.utils.db.managed.ManagedRocksObjectUtils.formatStackTrace;
+import static 
org.apache.hadoop.hdds.utils.db.managed.ManagedRocksObjectUtils.getStackTrace;
+
 /**
  * Managed BloomFilter.
  */
 public class ManagedBloomFilter extends BloomFilter {
 
+  private final StackTraceElement[] elements = getStackTrace();

Review Comment:
   I guess it's more obvious if stacktrace is an 
`Optional<StackTraceElement[]>` to it's not always available (disabled in 
prod). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to