errose28 commented on code in PR #5621:
URL: https://github.com/apache/ozone/pull/5621#discussion_r1399808792
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -188,6 +188,9 @@ public final class OzoneConfigKeys {
"ozone.client.ec.grpc.write.timeout";
public static final String OZONE_CLIENT_EC_GRPC_WRITE_TIMEOUT_DEFAULT =
"30s";
+ public static final String OZONE_EC_GRPC_ZERO_COPY_ENABLED =
"ozone.ec.grpc.zerocopy.enabled";
+ public static final boolean OZONE_EC_GRPC_ZERO_COPY_ENABLED_DEFAULT = false;
Review Comment:
Why do we need a feature flag for this? This requires us maintaining and
testing two different code paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
