duongkame commented on code in PR #5621:
URL: https://github.com/apache/ozone/pull/5621#discussion_r1399911853
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -188,6 +188,9 @@ public final class OzoneConfigKeys {
"ozone.client.ec.grpc.write.timeout";
public static final String OZONE_CLIENT_EC_GRPC_WRITE_TIMEOUT_DEFAULT =
"30s";
+ public static final String OZONE_EC_GRPC_ZERO_COPY_ENABLED =
"ozone.ec.grpc.zerocopy.enabled";
+ public static final boolean OZONE_EC_GRPC_ZERO_COPY_ENABLED_DEFAULT = false;
Review Comment:
Good point. I'm also not sure about this and open for suggestions. Guess
it's worth giving clients a chance to disable this optimization so that they
don't need to rollback an entire major ozone version (say ozone 1.4 or 1.5) if
running into problems with zero-copy.
I think we should have it enabled by default to have all the existing
integration tests go through it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
