tanvipenumudy commented on code in PR #5519:
URL: https://github.com/apache/ozone/pull/5519#discussion_r1401588280
##########
hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/StorageSize.java:
##########
@@ -91,6 +91,19 @@ public static StorageSize parse(String value) {
}
+ public static StorageSize parse(String value, StorageUnit defaultUnit) {
+ try {
+ return parse(value);
+ } catch (IllegalArgumentException e) {
+ try {
+ return parse(value + defaultUnit.getShortName());
Review Comment:
Thank you @ayushtkn for the review, I have incorporated the review comments
and modified the existing test cases to incorporate the newer changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
