sodonnel commented on PR #5632:
URL: https://github.com/apache/ozone/pull/5632#issuecomment-1830164645
One strange case we have is for DELETED containers - they always return true:
```
if (containerState == HddsProtos.LifeCycleState.DELETED) {
LOG.debug("Container {} is DELETED so returning true", containerInfo);
return true;
}
```
For decommission, it should not see a deleted container, as for it to be
deleted, the replicas should be removed, and hence the datanode being
decommissioned will not have any copies. We do have a check in decommission
already for deleting / deleted to ignore them, so that is easy to work with.
But the quasi-closed which can be forced closed is an interesting problem -
should we return true here (we do currently)? What if, the replicas are failing
to close somehow, and it is under-replicated by 1. It will never get closed and
it will never check for under-replication either. Perhaps we should try to
close it, and return false to let the other handlers run too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
