sodonnel commented on PR #5632: URL: https://github.com/apache/ozone/pull/5632#issuecomment-1835840522
I do agree that we need to keep the readonly aspect in mind for future changes. However even if a handler was introduced that did not honor the read-only aspect, it would probably do no harm - on the next run of RM, RM will process the container and do the same think anyway. All the handler are, or should be idempotent, so running them multiple times should do no harm. I did consider not making the handler read-only, but I though it was better if on the RM run triggered any actions, rather than other actors potentially triggering them. This stuff could be improved later in other PRs if it becomes a problem. I pushed a change for the other two comments too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
