sodonnel commented on code in PR #5688:
URL: https://github.com/apache/ozone/pull/5688#discussion_r1409028168
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionMetrics.java:
##########
@@ -135,10 +135,13 @@ public long getUnhealthyContainers() {
private Map<String, ContainerStateInWorkflow> metricsByHost;
+ private Map<String, Long> startTimeByHost;
+
/** Private constructor. */
private NodeDecommissionMetrics() {
this.registry = new MetricsRegistry(METRICS_SOURCE_NAME);
metricsByHost = new HashMap<>();
+ startTimeByHost = new HashMap<>();
Review Comment:
An advantage of holding all the relevant details in trackedNodes, would be
that to display these on the client, you don't even need to go to the metrics
class and call individual getters - you could just return the trackedNodes set
to the client, and it can display whatever is in it. Then the details are sent
to the metrics as now to allow them to be displayed via metrics utilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
