hemantk-12 commented on code in PR #5719:
URL: https://github.com/apache/ozone/pull/5719#discussion_r1414089964
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -289,28 +289,31 @@ public PersistentMap<String, SnapshotDiffJob>
getSnapDiffJobTable() {
private Optional<ManagedSSTDumpTool> initSSTDumpTool(
final OzoneConfiguration conf) {
- try {
- int threadPoolSize = conf.getInt(
- OMConfigKeys.OZONE_OM_SNAPSHOT_SST_DUMPTOOL_EXECUTOR_POOL_SIZE,
- OMConfigKeys
- .OZONE_OM_SNAPSHOT_SST_DUMPTOOL_EXECUTOR_POOL_SIZE_DEFAULT);
- int bufferSize = (int) conf.getStorageSize(
- OMConfigKeys.OZONE_OM_SNAPSHOT_SST_DUMPTOOL_EXECUTOR_BUFFER_SIZE,
- OMConfigKeys
- .OZONE_OM_SNAPSHOT_SST_DUMPTOOL_EXECUTOR_BUFFER_SIZE_DEFAULT,
- StorageUnit.BYTES);
- this.sstDumpToolExecService = Optional.of(new ThreadPoolExecutor(0,
- threadPoolSize, 60, TimeUnit.SECONDS,
- new SynchronousQueue<>(), new ThreadFactoryBuilder()
- .setNameFormat(ozoneManager.getThreadNamePrefix() +
- "snapshot-diff-manager-sst-dump-tool-TID-%d")
- .build(),
- new ThreadPoolExecutor.DiscardPolicy()));
- return Optional.of(new ManagedSSTDumpTool(sstDumpToolExecService.get(),
- bufferSize));
- } catch (NativeLibraryNotLoadedException e) {
- this.sstDumpToolExecService.ifPresent(exec ->
- closeExecutorService(exec, "SstDumpToolExecutor"));
+ if (conf.getBoolean(OMConfigKeys.OZONE_OM_SNAPSHOT_NATIVE_LIB_ENABLED_DIFF,
Review Comment:
I was assuming that snap diff would fail if rocksDB native tool is not
loaded and I asked the same in previous comment.
Looking at snapshot diff code, it doesn't seem that way.
https://github.com/apache/ozone/blob/15c77c6e9bb22a0bbf5d0080f81c9310051229a9/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java#L1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
