hemantk-12 commented on code in PR #5719:
URL: https://github.com/apache/ozone/pull/5719#discussion_r1422382424
##########
hadoop-hdds/rocks-native/src/main/java/org/apache/hadoop/hdds/utils/db/managed/PipeInputStream.java:
##########
@@ -43,7 +39,8 @@ public class PipeInputStream extends InputStream {
private AtomicBoolean cleanup;
PipeInputStream(int capacity) throws NativeLibraryNotLoadedException {
- if (!NativeLibraryLoader.isLibraryLoaded(ROCKS_TOOLS_NATIVE_LIBRARY_NAME))
{
+ if (!NativeLibraryLoader.getInstance()
Review Comment:
I get that but `PipeInputStream` is only initialized inside
`ManagedSSTDumpTool`. If initialization of `ManagedSSTDumpTool` fails because
of native lib not getting loaded, `PipeInputStream` will never be initialized.
My point is native lib must have been loaded by this time. If not, then it is a
problem.
If `PipeInputStream` was getting instantiation independently of
`ManagedSSTDumpTool`, then it makes sense to load native lib here. Another
reason is that we don't check if `ozone.om.snapshot.load.native.lib` is enabled
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
