aswinshakil commented on code in PR #5751:
URL: https://github.com/apache/ozone/pull/5751#discussion_r1424334482
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java:
##########
@@ -230,21 +231,19 @@ public ReferenceCounted<IOmMetadataReader, SnapshotCache>
get(String key,
* @param key snapshot table key
*/
public void release(String key) {
- dbMap.compute(key, (k, v) -> {
- if (v == null) {
- throw new IllegalArgumentException(
- "Key '" + key + "' does not exist in cache");
- }
+ ReferenceCounted<IOmMetadataReader, SnapshotCache>
+ rcOmSnapshot = dbMap.get(key);
+ if (rcOmSnapshot == null) {
+ throw new IllegalArgumentException(
+ "Key '" + key + "' does not exist in cache");
+ }
- if (v.decrementRefCount() == 0L) {
- synchronized (pendingEvictionList) {
- // v is eligible to be evicted and closed
- pendingEvictionList.add(v);
- }
+ if (rcOmSnapshot.decrementRefCount() == 0L) {
+ synchronized (pendingEvictionList) {
+ // v is eligible to be evicted and closed
+ pendingEvictionList.add(rcOmSnapshot);
}
-
- return v;
- });
+ }
Review Comment:
@smengcl From the code I don't see `release()` being used anywhere. How do
we decrement reference count if we don't use `release()`. The only other place
we decrement reference count is in `get()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
