szetszwo commented on PR #5766: URL: https://github.com/apache/ozone/pull/5766#issuecomment-1857055137
@adoroszlai , since `CompositeCrcFileChecksum` is a subclass implementation of `FileChecksum`, where `FileChecksum` is the public API. Copying the code from Hadoop should work, although it may be complicated. Falling back to another implementation may not be useful. E.g., distcp computes checksums to decide whether it should copy. If the source supports `CompositeCrcFileChecksum` but the destination does not, computing a fallback checksum in the destination is not helpful. If copying the code from Hadoop is too complicated, this pull request may catch the `NoClassDefFoundError` and throws a more informational exception. We may work on the fix separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
