adoroszlai commented on PR #5766: URL: https://github.com/apache/ozone/pull/5766#issuecomment-1857758656
> Falling back to another implementation may not be useful. E.g., distcp computes checksums to decide whether it should copy. If the source supports `CompositeCrcFileChecksum` but the destination does not, computing a fallback checksum in the destination is not helpful. Thanks @szetszwo for the bigger picture. I have created #5799 with the new approach. It turned out to be simpler than I thought: only one new method from `DataChecksum` (existing class) had to be copied to `CrcUtil` (new class). If you find the other PR to be OK, we can abandon this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
