dombizita commented on PR #5812: URL: https://github.com/apache/ozone/pull/5812#issuecomment-1875360359
Thanks for working on this @ArafatKhan2198! Your comments on the jira are really useful for the context, thanks for the detailed analysis there!! Please correct me if I'm wrong, but in the end the current functionality is correct, right? Right now the Ratis pipelines are pre-created, so during Recon's startup when the pipeline sync task runs it will register those pipelines. So if Recon sees a Ratis container associated with the initially created pipelines everything will be fine, the container will be added to Recon. But I believe if later we have new Ratis pipelines this problem will also occur, like with EC. The problem is that with EC pipelines this will always happen, as default we don't have any, we create them only when we want to create a key with EC (right?). But after 5 minutes (or the value of the config) when the pipeline sync task ran the EC pipeline will be there in Recon and the container will be added with the pipeline. I think the title of the jira is misleading, as SCM stores the EC containers, only problem is that it is delayed because of the pipeline sync task. What do you think of this @ArafatKhan2198 @xBis7, is this correct? I tried to look into the history of this code you changed and why was this part there like that before: https://github.com/apache/ozone/blob/9f475809d24598cd2b99fa62af93e638ab31860b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconContainerManager.java#L240-L245 But I couldn't find the reason. My concern is that maybe there are some cases we can't think of right now that will also be affected with this change and we will add pipelines to Recon outside of the pipeline sync task. What do you think, this won't cause problems? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
