sumitagrawl commented on PR #5812: URL: https://github.com/apache/ozone/pull/5812#issuecomment-1875484317
> I hadn't followed up on this. > > From @ArafatKhan2198's comments and what I see on master, the actual issue is that every time a new pipeline is created, we have to wait for the `PipelineSyncTask` to run, so that the pipeline is registered. After that, the containers associated with that pipeline, will no longer be considered unknown and will be stored. > > > But I believe if later we have new Ratis pipelines this problem will also occur, like with EC. > > @dombizita You are right, this will occur for every new pipeline creation. When I created the jira, I hadn't done an analysis to see that Ratis pipelines are pre-created and that makes Recon pickup the containers associated with them immediately. > > Based on all that, I think we need to reconsider the approach on this PR. Since Recon stores pipelines using the sync task, doing it in a second place in the code, creates confusion and it can also lead to bugs. Recon is evolved from SCM having the strict check. Can not find any background but have fixed multiple issue for adding container like container in closed state. Can not find any impact with this logic, as here, its getting pipeline information from SCM associated with container, same is used to update the pipeline and then container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
