sumitagrawl commented on code in PR #5891:
URL: https://github.com/apache/ozone/pull/5891#discussion_r1441378807
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java:
##########
@@ -276,14 +275,8 @@ void initClusterAndEnv() throws IOException,
InterruptedException, TimeoutExcept
-> (RootedOzoneFileSystem) FileSystem.get(conf));
if (useOnlyCache) {
- if (omRatisEnabled) {
Review Comment:
here we are removing test scenario, where ratis is enabled, but double
buffer is not flushed, and entire operation works over cache only. This is to
catch issues when double buffer is taking to flush.
Please check if this test scenario can be enabled back?
The testcase is blocking as daemon is shutdown in this case, this test cases
fixed with,
https://github.com/apache/ozone/pull/5857/commits/493323a2632a5f28f0486f775e50c1817de941b1
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java:
##########
@@ -591,9 +591,10 @@ public void start() throws IOException {
}
public void stop() {
+ LOG.info("Stopping {} at port {}", this, port);
try {
+ // Ratis will also close the state machine
server.close();
- omStateMachine.close();
Review Comment:
I faced same problem that omStateMachine when stopped, takeSnapshot() block
for double buffer flush. Below changes may be requried for this PR, and need
revert omStateMachine.close()
https://github.com/apache/ozone/pull/5857/commits/493323a2632a5f28f0486f775e50c1817de941b1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
