szetszwo commented on code in PR #5891:
URL: https://github.com/apache/ozone/pull/5891#discussion_r1446345096
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java:
##########
@@ -591,9 +591,10 @@ public void start() throws IOException {
}
public void stop() {
+ LOG.info("Stopping {} at port {}", this, port);
try {
+ // Ratis will also close the state machine
server.close();
- omStateMachine.close();
Review Comment:
> ... takeSnapshot() block for double buffer flush. ...
That is a good point. Let's add a check in `takeSnapshot()`.
> ... need revert omStateMachine.close()
`RaftServer` will close `omStateMachine`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
