devmadhuu opened a new pull request, #5928:
URL: https://github.com/apache/ozone/pull/5928

   ## What changes were proposed in this pull request?
   This PR fixes the intermittent failure of 
`TestStorageContainerManager#testBlockDeletionTransactions` test case.
   
   This test case creates 5 new keys and 5 containers as well. Then close all 5 
containers and creates the delete transaction log and immediately verifies the 
number of valid delete transactions is > 0 (`delLog.getNumOfValidTransactions() 
> 0`), But after sometime SCM Block Deleting service thread will send the 
DELETE BLOCK command to datanodes and commits the cleanup the delete block 
transaction log from `DeletedBlocksTransaction` table. So after few seconds 
this assertion of `delLog.getNumOfValidTransactions() == 0` should pass. But 
there was an issue in test case. that after closing all containers, some 
containers were left OPEN due to which delete block transactions still kept 
lying in `DeletedBlocksTransaction` table even after 25 seconds. So this PR 
updates few configurations related to DN heartbeats interval and add a sleep to 
give sometime for containers to get closed.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8492
   
   ## How was this patch tested?
   
   This patch is tested by running repeated CI runs of multiple iterations (200 
iterations in CI flaky workflow). Here is the green CI 
[link](https://github.com/devmadhuu/ozone/actions/runs/7418271397).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to