xichen01 commented on code in PR #5928:
URL: https://github.com/apache/ozone/pull/5928#discussion_r1447990446
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java:
##########
@@ -311,7 +324,7 @@ public void testBlockDeletionTransactions() throws
Exception {
OzoneTestUtils.closeContainers(keyInfo.getKeyLocationVersions(),
Review Comment:
I see that the other tests have similar logic (such as:
`testBlockDeletingThrottling`, it close `Container` too). Is it possible to
have the same bugs.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManager.java:
##########
@@ -311,7 +324,7 @@ public void testBlockDeletionTransactions() throws
Exception {
OzoneTestUtils.closeContainers(keyInfo.getKeyLocationVersions(),
cluster.getStorageContainerManager());
}
-
+ Thread.sleep(3000);
Review Comment:
Can use this method to wait for the Container to close but need get the
Container list first.
https://github.com/apache/ozone/blob/de76edc0e1ecb4516b0232e21336b889d5d1081f/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/TestHelper.java#L326-L327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
