adoroszlai opened a new pull request, #5936:
URL: https://github.com/apache/ozone/pull/5936

   ## What changes were proposed in this pull request?
   
   If `flaky-test-check` is triggered for a specific method, it checks if the 
method exists in the test class.  This does not work for test methods inherited 
from parent class.
   
   ```
   Test method testValidateBlockLengthWithCommitKey does not exist in 
TestSecureOzoneRpcClient.java.Stopping!
   ```
   
   
https://github.com/adoroszlai/ozone/actions/runs/7431424440/job/20222159860#step:3:33
   
   However, the same test method is accepted for the parent class, which is 
cannot be run, since it's abstract.
   
   I propose removing this safety check.  If the specified method cannot be 
run, build output will show `Tests run: 0`.
   
   https://issues.apache.org/jira/browse/HDDS-10079
   
   ## How was this patch tested?
   
   https://github.com/adoroszlai/ozone/actions/runs/7431422827


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to