adoroszlai commented on PR #5936: URL: https://github.com/apache/ozone/pull/5936#issuecomment-1880511563
> > If the specified method cannot be run, build output will show Tests run: 0. > > I guess the job would still pass though giving a false sense of success to user. I'm okay with current change given the parent class problem, but this would mean we need to check thoroughly when someone posts a successful job link. Should we fail if no tests are run? You are right, the job would still pass. I've filed HDDS-10080 to fail fast (after first iteration) in `junit.sh` if no tests were run. BTW, this can happen even prior to this patch, e.g. if I try to run `TestOzoneRpcClientAbstract`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
