adoroszlai opened a new pull request, #5939:
URL: https://github.com/apache/ozone/pull/5939
## What changes were proposed in this pull request?
Ozone relies on base test classes from Hadoop for:
* `TestOzoneConfigurationFields`
* filesystem contract tests
Currently those base classes are implemented using JUnit4 (migration is in
progress in Hadoop repo).
This PR:
* copies the base classes from Hadoop 3.3.6
* migrates them to JUnit5 as much as possible (incorporating in-progress
changes from Hadoop) without touching the concrete implementation subclasses in
Ozone
`TestConfigurationFieldsBase` is completely migrated.
Abstract contract tests:
* assertions migrated to AssertJ (HADOOP-19025)
* `extends Assert` removed from `AbstractFSContractTestBase` and
`ContractTestUtils`
* JUnit5 lifecycle annotations added (but JUnit4-ones also kept)
* `@Test` annotations left unchanged (still using JUnit4)
* slightly tweaked for checkstyle/findbugs (but still need some
suppression), since rules in Hadoop seem more lenient
Most Ozone contract tests use `Parameterized` runner, which requires quite
some refactoring for migrating to JUnit5. HDDS-10074 will finish that by
refactoring Ozone's contract tests to JUnit5, and simply replacing `@Test`
annotations in the abstract contract test base classes.
https://issues.apache.org/jira/browse/HDDS-10081
## How was this patch tested?
Existing _integration (contract)_ check in
[CI](https://github.com/adoroszlai/ozone/actions/runs/7439172167/job/20238914151#step:6:142):
```
Tests run: 357, Failures: 0, Errors: 0, Skipped: 6
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
