adoroszlai commented on PR #5939: URL: https://github.com/apache/ozone/pull/5939#issuecomment-1884910197
This might seem to be a large change, but most of the code is copied from Hadoop. Since this code is intended to be temporary in Ozone, I don't think we need to inspect it in detail, or adapt to Ozone coding conventions (beyond what checkstyle/findbugs complains about). Having the same number of tests before/after the change, and with all tests passing, I think it should be fine. If it helps during review, the follow-up change (conversion of Ozone contract tests to JUnit5) can be peeked at: https://github.com/adoroszlai/ozone/commit/708f49bdb8fb52c770e581bb9d74c9fb28a1f38c. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
