devmadhuu commented on code in PR #5841:
URL: https://github.com/apache/ozone/pull/5841#discussion_r1447255726
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -142,9 +158,14 @@ public void triggerContainerHealthCheck() {
" processing {} containers.", Time.monotonicNow() - start,
containers.size());
logUnhealthyContainerStats(unhealthyContainerStateStatsMap);
- processedContainers.clear();
- } finally {
- lock.writeLock().unlock();
+ if (containers.size() > Integer.parseInt(DEFAULT_FETCH_COUNT)) {
+ startID = ContainerID.valueOf(
+ containers.get(containers.size() - 1).getContainerID());
+ containers.clear();
+ containers = containerManager.getContainers(startID,
+ Integer.parseInt(DEFAULT_FETCH_COUNT));
+ }
+ containers.clear();
Review Comment:
As discussed, we have a case where last iteration in batch will not execute
the if condition , so need to clear -off any in memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
