adoroszlai commented on code in PR #5841:
URL: https://github.com/apache/ozone/pull/5841#discussion_r1451745457
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/fsck/TestContainerHealthTask.java:
##########
@@ -299,7 +304,7 @@ public void testDeletedContainer() throws Exception {
.thenReturn(new ContainerWithPipeline(mockContainers.get(0), null));
List<UnhealthyContainers> all = unHealthyContainersTableHandle.findAll();
- assertThat(all).isEmpty();
+ assertTrue(all.isEmpty());
Review Comment:
Please keep `assertThat`, added by HDDS-10034.
```suggestion
assertThat(all).isEmpty();
```
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/fsck/TestContainerHealthTask.java:
##########
@@ -192,7 +195,8 @@ public void testRun() throws Exception {
ReconTaskStatus taskStatus =
reconTaskStatusDao.findById(containerHealthTask.getTaskName());
-
assertThat(taskStatus.getLastUpdatedTimestamp()).isGreaterThan(currentTime);
+ assertTrue(taskStatus.getLastUpdatedTimestamp() >
+ currentTime);
Review Comment:
Please keep `assertThat`, added by HDDS-10034.
```suggestion
assertThat(taskStatus.getLastUpdatedTimestamp()).isGreaterThan(currentTime);
```
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/fsck/TestContainerHealthTask.java:
##########
@@ -137,7 +140,7 @@ public void testRun() throws Exception {
.thenReturn(Collections.emptySet());
List<UnhealthyContainers> all = unHealthyContainersTableHandle.findAll();
- assertThat(all).isEmpty();
+ assertTrue(all.isEmpty());
Review Comment:
Please keep `assertThat`, added by HDDS-10034.
```suggestion
assertThat(all).isEmpty();
```
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/fsck/TestContainerHealthTask.java:
##########
@@ -327,7 +332,8 @@ public void testDeletedContainer() throws Exception {
ReconTaskStatus taskStatus =
reconTaskStatusDao.findById(containerHealthTask.getTaskName());
-
assertThat(taskStatus.getLastUpdatedTimestamp()).isGreaterThan(currentTime);
+ assertTrue(taskStatus.getLastUpdatedTimestamp() >
+ currentTime);
Review Comment:
Please keep `assertThat`, added by HDDS-10034.
```suggestion
assertThat(taskStatus.getLastUpdatedTimestamp()).isGreaterThan(currentTime);
```
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/fsck/TestContainerHealthTask.java:
##########
@@ -19,9 +19,11 @@
package org.apache.hadoop.ozone.recon.fsck;
import static
org.hadoop.ozone.recon.schema.ContainerSchemaDefinition.UnHealthyContainerStates.ALL_REPLICAS_UNHEALTHY;
-import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
Review Comment:
Please keep `assertThat` instead of restoring `assertTrue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
