JiangHua Zhu created HDDS-10133:
-----------------------------------

             Summary: Add a method to check key name in OMKeyRequest
                 Key: HDDS-10133
                 URL: https://issues.apache.org/jira/browse/HDDS-10133
             Project: Apache Ozone
          Issue Type: Improvement
          Components: OM
    Affects Versions: 1.3.0
            Reporter: JiangHua Zhu


There is logic for checking key names in OMFileCreateRequest, 
OMKeyCommitRequest, OMKeyCreateRequest, and OMKeyRenameRequest.
OMFileCreateRequest:

{code:java}
final boolean checkKeyNameEnabled = ozoneManager.getConfiguration()
         .getBoolean(OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_KEY,
                 OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT);
    if (checkKeyNameEnabled) {
      OmUtils.validateKeyName(StringUtils.removeEnd(keyArgs.getKeyName(),
              OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX));
    }
{code}

OnKeyCommitRequest:

{code:java}
final boolean checkKeyNameEnabled = ozoneManager.getConfiguration()
         .getBoolean(OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_KEY,
                 OMConfigKeys.OZONE_OM_KEYNAME_CHARACTER_CHECK_ENABLED_DEFAULT);
    if (checkKeyNameEnabled) {
      OmUtils.validateKeyName(StringUtils.removeEnd(keyArgs.getKeyName(),
              OzoneConsts.FS_FILE_COPYING_TEMP_SUFFIX));
    }
{code}



We can unify them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to