adoroszlai opened a new pull request, #6008:
URL: https://github.com/apache/ozone/pull/6008

   ## What changes were proposed in this pull request?
   
   Several client tests that compare volume/bucket creation time to 
`Instant.now()` as of the start of the test failed because `now()` may include 
a nanosecond component, while creation time is recorded with millisecond 
precision only.
   
   
https://github.com/apache/ozone/blob/02bfa7f91d9442381503ec001f28c2de19c2897b/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java#L171
   
   This is fixed by using `Instant.ofEpochMillis` to record test start time, 
too.
   
   https://issues.apache.org/jira/browse/HDDS-10119
   
   ## How was this patch tested?
   
   Tested locally with Java 17:
   
   ```
   $ JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 \
     ./hadoop-ozone/dev-support/checks/junit.sh -am -pl :ozone-integration-test 
-DexcludedGroups=unhealthy \
     
-Dtest="TestOzoneAtRestEncryption,TestOzoneClient,TestOzoneRpcClient,TestOzoneRpcClientWithRatis,TestSecureOzoneRpcClient,TestStorageContainerManagerHA"
   ...
   [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.681 
s -- in org.apache.hadoop.ozone.client.TestOzoneClient
   ...
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.4 
s -- in org.apache.hadoop.ozone.scm.TestStorageContainerManagerHA
   [INFO] Tests run: 123, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.78 s -- in org.apache.hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
   [INFO] Tests run: 121, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
50.17 s -- in org.apache.hadoop.ozone.client.rpc.TestOzoneRpcClient
   [INFO] Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
35.50 s -- in org.apache.hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
   [INFO] Tests run: 125, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
63.53 s -- in org.apache.hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
   ```
   
   Regular CI (with Java 8):
   https://github.com/adoroszlai/ozone/actions/runs/7538133915


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to