swamirishi commented on code in PR #5970:
URL: https://github.com/apache/ozone/pull/5970#discussion_r1453652570
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ListIterator.java:
##########
@@ -236,14 +241,38 @@ private void
populateCacheMap(Iterator<Map.Entry<CacheKey<String>,
}
}
+ public boolean doesKeyExistInCache(String key) {
+ return cacheKeyMap.containsKey(key);
+ }
+
+ private void getNextKey() throws IOException {
+ while (cacheCreatedKeyIter.hasNext() && currentKey == null) {
+ Map.Entry<String, Value> entry = cacheCreatedKeyIter.next();
+ if (null == entry.getValue()) {
Review Comment:
@sumitagrawl @devmadhuu I am surely missing something here. Correct me if I
am wrong, we are doing a continue here as per this statement which will skip
the null value here. So all I am asking is when we are initializing
cacheCreatedKeyIter can we skip null values? The key would be still there in
the cacheKeyMap. It will make this code much simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
