hemantk-12 commented on code in PR #5970:
URL: https://github.com/apache/ozone/pull/5970#discussion_r1449389595
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ListIterator.java:
##########
@@ -191,15 +191,15 @@ public static class CacheIter<Value>
private final String prefixKey;
private final String startKey;
private final String tableName;
-
+ private HeapEntry currentKey;
Review Comment:
nit: `currentEntry` and `getCurrentEntry()`
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ListIterator.java:
##########
@@ -303,11 +323,12 @@ public static class MinHeapIterator implements
ClosableIterator {
for (Table table : tables) {
CacheIter cacheIter = new CacheIter<>(iteratorId, table.getName(),
table.cacheIterator(), startKey, prefixKey);
- Predicate<String> isKeyExistInCache = cacheIter::isKeyExistInCache;
+ Predicate<String> doesKeyExistInCache =
Review Comment:
nit: JFYI, now char limit is 120. It can be fit in one line.
Configure/update your IDE with latest ozone-style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
