ivandika3 commented on code in PR #5668:
URL: https://github.com/apache/ozone/pull/5668#discussion_r1461326394
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartUploadCompleteList.java:
##########
@@ -56,8 +56,8 @@ public Map<Integer, String> getMultipartMap() {
*/
public List<Part> getPartsList() {
List<Part> partList = new ArrayList<>();
- multipartMap.forEach((partNumber, partName) -> partList.add(Part
-
.newBuilder().setPartName(partName).setPartNumber(partNumber).build()));
+ multipartMap.forEach((partNumber, eTag) -> partList.add(Part
+ .newBuilder().setETag(eTag).setPartNumber(partNumber).build()));
Review Comment:
Also related to the protobuf compatibillity, is it possible to set both
partName and eTag to the same value?
```java
multipartMap.forEach((partNumber, eTag) -> partList.add(Part
.newBuilder().setPartName(eTag).setETag(eTag).setPartNumber(partNumber).build()));
```
Then we can also put a comment to explain the rationale behind setting the
eTag for both partName and eTag fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
