adoroszlai commented on PR #5668: URL: https://github.com/apache/ozone/pull/5668#issuecomment-1910407532
> The notice from @adoroszlai was: > > proto.lock should not be updated as part of the PR. The reason for having this file is to ensure backwards compatibility of any changes to .proto definitions. Lock files are used as the reference against which proto definitions are validated. > > My reply to the notice above was: > > > How should we resolve the compatibility check failure in a maven build if the proto.lock won't be updated? @vtutrinov Thanks for re-posting, I don't see the same question anywhere else in PR. Regarding the question: proto definitions need to be changed in a way to be backwards compatible. For this PR, reverting the change of `proto.lock`, backwards compatibility check is still passing for me. Are you encountering some failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
