sumitagrawl commented on code in PR #6046:
URL: https://github.com/apache/ozone/pull/6046#discussion_r1462772760
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1888,19 +1859,19 @@ public ExpiredOpenKeys getExpiredOpenKeys(Duration
expireThreshold,
} else {
// add hsync'ed keys
final KeyArgs.Builder keyArgs = KeyArgs.newBuilder()
- .setVolumeName(info.getVolumeName())
- .setBucketName(info.getBucketName())
- .setKeyName(info.getKeyName())
- .setDataSize(info.getDataSize());
- java.util.Optional.ofNullable(info.getLatestVersionLocations())
+ .setVolumeName(openKeyInfo.getVolumeName())
+ .setBucketName(openKeyInfo.getBucketName())
+ .setKeyName(openKeyInfo.getKeyName())
+ .setDataSize(openKeyInfo.getDataSize());
Review Comment:
info used to have last commited datasize, commited blocks, but openKeyInfo
may not have that information correctly. So IMO, can not use openKeyInfo for
commit purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
