smengcl commented on PR #6046: URL: https://github.com/apache/ozone/pull/6046#issuecomment-1905375966
> @smengcl Thanks for working over this, having few query, > > 1. adding metadata while commit will not resolve missing hsync commit for first time till fsync not called by client. Do we have plan to resolve by adding hsync flag while open keyfile ? Which issue are you talking about? If it is another existing jira then it is not in the scope of this PR. > 2. Related to performance, this interface will not be called in normal path. additionally checking key existence for open key is very fast. Do this provide any measurable performance improvement? It's not merely checking key existence in KeyTable, it is extra key look up + extra DB value deserialization + metadata check. Deserialization the large value byte array that stores `OmKeyInfo` is probably more expensive than DB get(seek). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
