sumitagrawl commented on PR #5964: URL: https://github.com/apache/ozone/pull/5964#issuecomment-1907429940
> Thanks for looking at this issue @sumitagrawl. I think the actual problem is that the container reader is being run before the volume is formatted, and that is what we should be fixing. Volume format is done only after GETVERSION SCM call, but container and volume set is prepared before that only. I think the reason of this doing earlier during startup was to be ready before SCM Registeration. We should move buildContainerSet() from OzoneContainer constructor to VersionEndpointTask after GETVERSION SCM call. Related to functionality impact while moving, does not seems any impact. > I believe the only fix required here is to not start the `ContainerReaders` until the `OzoneContainer` is started. However, I do not yet understand why this did not fail earlier. The `occurrence is rare `when cleanup of container is not complete during previous shutdown. so this is not observed. Even in UT case, complete initialization is done of Volume object which is different from startup flow, so missed that point also. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
