errose28 commented on PR #5964: URL: https://github.com/apache/ozone/pull/5964#issuecomment-1911037978
Yeah we might have to do some refactoring to make sure the `OzoneContainer` does not need the `containerSet` initialized before it is started. > The occurrence is rare when cleanup of container is not complete during previous shutdown. so this is not observed. [This code](https://github.com/apache/ozone/blob/dc0a10403a069892aec8152a65d646eeccd43a1d/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerReader.java#L125) would run regardless of any container cleanup and I would expect it to throw an NPE before any other `ContainerReader` code, including cleanup, even started. The volume must have been formatted if a container already existed there, so I'm not sure why this is not happening. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
