ChenSammi commented on code in PR #6052:
URL: https://github.com/apache/ozone/pull/6052#discussion_r1469249940


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java:
##########
@@ -154,6 +155,31 @@ public int getPort() {
     return port;
   }
 
+  public void setPoolSize(int size) {

Review Comment:
   There is one ReplicationServer, acting as the server to provide data to 
remote replication request,  and one ReplicationSupervisor, acting as the peer 
to start the replication request(either pull or push).  This patch adds the 
dynamic reconfiguration for ReplicationServer only, while the dynamic 
reconfiguration for ReplicationSupervisor is not covered.  @guohao-rosicky , I 
think you can add the support for ReplicationSupervisor in this patch, or you 
can open a new JIRA to do that, both will be fine. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to