sodonnel commented on code in PR #6052:
URL: https://github.com/apache/ozone/pull/6052#discussion_r1469754154


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java:
##########
@@ -154,6 +155,31 @@ public int getPort() {
     return port;
   }
 
+  public void setPoolSize(int size) {

Review Comment:
   I was getting confused between the replicationServer and 
replicationSupervisor. They both share the same config key `streams.limit`.
   
   The current default is push replication, so the total number of containers 
any node will push is governed by streams.limit on that node. On the receiving 
nodes, the total threads in the pool for receiving is also streams.limit. To 
improve the transfer rate, it is probably most important to increase the 
replicationSupervisor threads, although the server limit might have an effect 
in some cases.
   
   I don't mind if we increase only the server side here, and address the 
replicationSupervisor threads later. If you want to do that in another Jira, 
please open the Jira and link it to this one or mention it in this PR so we can 
find it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to