ivandika3 commented on code in PR #5668:
URL: https://github.com/apache/ozone/pull/5668#discussion_r1469282890
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java:
##########
@@ -642,10 +661,36 @@ private String multipartUploadedKeyHash(
StringBuffer keysConcatenated = new StringBuffer();
for (PartKeyInfo partKeyInfo: partsList) {
keysConcatenated.append(KeyValueUtil.getFromProtobuf(partKeyInfo
- .getPartKeyInfo().getMetadataList()).get("ETag"));
+ .getPartKeyInfo().getMetadataList()).get(OzoneConsts.ETAG));
Review Comment:
Regarding the incomplete multipart uploads compatibility, the parts that do
not have "eTag" yet will return null. In `StringBuffer`, it will append four
characters "null". However, I think there is little we can do here, so I think
it should be fine to handle the incompatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
