fapifta commented on code in PR #6143:
URL: https://github.com/apache/ozone/pull/6143#discussion_r1474063505
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineStateManagerImpl.java:
##########
@@ -295,37 +295,36 @@ public void testGetPipelinesByTypeFactorAndState()
@Test
public void testAddAndGetContainer() throws IOException, TimeoutException {
- long containerID = 0;
Review Comment:
May I ask what is the rationale behind changing this long to AtomicLong? The
rest of the patch is really just changing exception testing to assertThrows, is
it by chance a leftover from some other work, or intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
