adoroszlai commented on code in PR #6143:
URL: https://github.com/apache/ozone/pull/6143#discussion_r1474119484
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineStateManagerImpl.java:
##########
@@ -295,37 +295,36 @@ public void testGetPipelinesByTypeFactorAndState()
@Test
public void testAddAndGetContainer() throws IOException, TimeoutException {
- long containerID = 0;
Review Comment:
I assume it is changed to be able to use in this lambda expression:
https://github.com/apache/ozone/blob/482ec1ac126e9b27b8d4659be56f09785eed28a3/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineStateManagerImpl.java#L322-L325
I think it's fine. If we want to minimize the diff, we could keep `long
containerID` and change the code above to something like this:
```java
ContainerID cid = ContainerID.valueOf(++containerID);
IOException e = assertThrows(IOException.class,
() -> stateManager.addContainerToPipeline(finalPipeline.getId(),
cid));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
