adoroszlai commented on code in PR #5791:
URL: https://github.com/apache/ozone/pull/5791#discussion_r1475552873
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2358,7 +2366,7 @@ private KeyOutputStream.Builder createKeyOutputStream(
.enableUnsafeByteBufferConversion(unsafeByteBufferConversion)
.setConfig(clientConfig)
.setAtomicKeyCreation(isS3GRequest.get())
- .setClientMetrics(clientMetrics)
+
.setBlockOutPutStreamResourceProvider(blockOutPutStreamResourceProvider)
Review Comment:
@xichen01 This part of response processing may not be fully safe for
multi-thread use:
https://github.com/apache/ozone/blob/6f507c9bb1a66e667006f8609a3e900950fedd20/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java#L490-L493
https://github.com/apache/ozone/blob/6f507c9bb1a66e667006f8609a3e900950fedd20/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/RatisBlockOutputStream.java#L108-L109
https://github.com/apache/ozone/blob/6f507c9bb1a66e667006f8609a3e900950fedd20/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/AbstractCommitWatcher.java#L76-L79
due to the `LinkedList`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
