xichen01 commented on code in PR #5791:
URL: https://github.com/apache/ozone/pull/5791#discussion_r1479595309
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2358,7 +2366,7 @@ private KeyOutputStream.Builder createKeyOutputStream(
.enableUnsafeByteBufferConversion(unsafeByteBufferConversion)
.setConfig(clientConfig)
.setAtomicKeyCreation(isS3GRequest.get())
- .setClientMetrics(clientMetrics)
+
.setBlockOutPutStreamResourceProvider(blockOutPutStreamResourceProvider)
Review Comment:
I noticed that the closure accesses a lot of external variables, which could
be a potential thread-safety issue, so I just added a "big" `synchronized`
here, which ensures that even if someone changes the code later on, there's
probably no thread-safety issue, and the `thenApplyAsync` just sets/creates the
variable, which is supposed to be lightweight.
So, I think the current approach is acceptable, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
