szetszwo commented on code in PR #6162:
URL: https://github.com/apache/ozone/pull/6162#discussion_r1479230805
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBufferImpl.java:
##########
@@ -35,6 +39,8 @@ public class ChecksumByteBufferImpl implements
ChecksumByteBuffer {
private final Checksum checksum;
Review Comment:
Sorry, my previous comment does not make sense. My suggestion is not to use
`CRC32` and `PureJavaCrc32C`.
https://github.com/apache/ozone/blob/5dd14acf4f0826fdb795866c274db301a7682981/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBufferFactory.java#L74-L76
We may
```java
return new PureJavaCrc32ByteBuffer();
```
Similarly,
https://github.com/apache/ozone/blob/5dd14acf4f0826fdb795866c274db301a7682981/hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBufferFactory.java#L88
We may
```java
return new PureJavaCrc32CByteBuffer();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
