szetszwo commented on code in PR #6162:
URL: https://github.com/apache/ozone/pull/6162#discussion_r1484656179
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/ChecksumByteBufferImpl.java:
##########
@@ -35,6 +39,8 @@ public class ChecksumByteBufferImpl implements
ChecksumByteBuffer {
private final Checksum checksum;
Review Comment:
> ... implementation in JDK9+ (e.g. in OpenJdk11) calculates using native
code on the native buffer directly and that probably indicates performance
advantages.
It is likely. We should benchmark it.
> ... but I'm not sure what's the advatages.
The advantage is to avoid creating an array and copying for (slow path)
direct buffers in Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
